Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize scripts to upload a model parameter repo to a new DB. #1109

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Generalize scripts to upload a model parameter repo to a new DB. #1109

merged 8 commits into from
Aug 30, 2024

Conversation

GernotMaier
Copy link
Contributor

@GernotMaier GernotMaier commented Aug 28, 2024 •
edited
Loading

Generalize scripts to upload a model parameter repo to a new DB:

  • until now: script could upload to a local DB
  • now: script can upload to any type of DB defined in the .env file (local running in a container or the remote DB)

Fixes also a bug in db_add_model_parameters_from_repository_to_db for cases when the given simulation DB was not available yet in the DB.

Notes on the changes in the scripts:

  • database_scripts/setup_local_db.sh: these is code moved from database_scripts/upload_from_model_repository_to_db.sh into this script (no other change)
  • database_scripts/upload_from_model_repository_to_local_db.sh has been renamed to database_scripts/upload_from_model_repository_to_db.sh (as it does not both the update to local and remote DB)

@GernotMaier GernotMaier self-assigned this Aug 28, 2024
@ctao-dpps-sonarqube CTAO-DPPS-SonarQube

This comment has been minimized.

Sign in to view
@ctao-dpps-sonarqube CTAO-DPPS-SonarQube

This comment has been minimized.

Sign in to view
@GernotMaier GernotMaier linked an issue Aug 28, 2024 that may be closed by this pull request
simtools-db-add-model-parameters-from-repository-to-db to a new database returns error #1108
Closed
@ctao-dpps-sonarqube CTAO-DPPS-SonarQube

This comment has been minimized.

Sign in to view
@GernotMaier
Copy link
Contributor Author

(review after merging of #1103)

@ctao-dpps-sonarqube CTAO-DPPS-SonarQube

This comment has been minimized.

Sign in to view
@ctao-dpps-sonarqube CTAO-DPPS-SonarQube
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (91.10% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

@GernotMaier GernotMaier marked this pull request as ready for review August 29, 2024 12:41
tobiaskleiner
tobiaskleiner approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@tobiaskleiner tobiaskleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@GernotMaier GernotMaier merged commit f7ffc3c into main Aug 30, 2024
18 checks passed
@GernotMaier GernotMaier deleted the general-db-upload-script branch August 30, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiaskleiner tobiaskleiner tobiaskleiner approved these changes

Assignees

@GernotMaier GernotMaier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simtools-db-add-model-parameters-from-repository-to-db to a new database returns error
2 participants
@GernotMaier @tobiaskleiner